Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route53-targets): InterfaceVpcEndpointTarget incorrectly accepts an imported endpoint #21523

Merged
merged 2 commits into from
Aug 9, 2022
Merged

fix(route53-targets): InterfaceVpcEndpointTarget incorrectly accepts an imported endpoint #21523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5311fa
fix(route53-targets): InterfaceVpcEndpoint target requires a
corymhall Aug 9, 2022
1fa03f1
Merge branch 'main' into corymhall/route53-targets/interface-vpc-endp…
corymhall Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions allowed-breaking-changes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ removed:@aws-cdk/aws-lambda-event-sources.SelfManagedKafkaEventSourceProps.onFai
# removed kubernetes version from EKS
removed:@aws-cdk/aws-eks.KubernetesVersion.V1_22

# change the type of vpcEndpoint from ec2.IInterfaceVpcEndpoint to ec2.InterfaceVpcEndpoint.
# even though it accepted IInterfaceVpcEndpoint, the actual implementation required a
# managed construct ec2.InterfaceVpcEndpoint
incompatible-argument:@aws-cdk/aws-route53-targets.InterfaceVpcEndpointTarget.<initializer>
# changed the type of requiresBootstrapStackVersion to Optional<number> (formerly number)
# to allow the CLI to skip validating the bootstrap stack when the stack is not needed
changed-type:@aws-cdk/cx-api.AssetManifestArtifact.requiresBootstrapStackVersion
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-route53-targets/lib/interface-vpc-endpoint-target.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as cdk from '@aws-cdk/core';
*/
export class InterfaceVpcEndpointTarget implements route53.IAliasRecordTarget {
private readonly cfnVpcEndpoint: ec2.CfnVPCEndpoint;
constructor(private readonly vpcEndpoint: ec2.IInterfaceVpcEndpoint) {
constructor(private readonly vpcEndpoint: ec2.InterfaceVpcEndpoint) {
this.cfnVpcEndpoint = this.vpcEndpoint.node.findChild('Resource') as ec2.CfnVPCEndpoint;
}

Expand Down