Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update cdk-from-cfn version #28619

Merged
merged 3 commits into from
Jan 8, 2024
Merged

chore: update cdk-from-cfn version #28619

merged 3 commits into from
Jan 8, 2024

Conversation

TheRealAmazonKendra
Copy link
Contributor

REPLACE THIS TEXT BLOCK

Describe the reason for this change, what the solution is, and any
important design decisions you made.

Remember to follow the CONTRIBUTING GUIDE and DESIGN GUIDELINES for any
code you submit.

Closes #.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 8, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 8, 2024 21:02
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 8, 2024
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

kaizencc
kaizencc approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll pretend you didn't hide some random test changes into this PR...

@TheRealAmazonKendra
Copy link
Contributor Author

I'll pretend you didn't hide some random test changes into this PR...

lol. I separated this update out from the automated PR to make the changes to the test more obvious.

@TheRealAmazonKendra
Copy link
Contributor Author

Pushed to test pipeline. Awaiting test run.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2303d93
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 178b845 into main Jan 8, 2024
10 of 11 checks passed
@mergify mergify bot deleted the TheRealAmazonKendra/cdk-from-cfn-update branch January 8, 2024 22:41
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRealAmazonKendra @aws-cdk-automation @kaizencc