chore(framework-integ): ELBv2 OIDC test disregards DOMAIN_NAME for DNS record #28804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test doesn't use the
DOMAIN_NAME
environment variable when trying to create the alias record. This results in a DNS resolution failure in the lambda function ifDOMAIN_NAME !== HOSTED_ZONE_NAME
.Using the
.
suffix at the end ensures that the resource will treat this as the FQDN so we don't have to worry about string splitting or parsing out the subdomain from the hosted zone name.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license