-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rds): addProxy can use kms encrypted secrets #28849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request for changes to integration tests as tests have been provided in |
a94387d
to
1574aca
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
When creating an RDS proxy if the Secrets Manager secret that holds the Credentials is encrypted with a KMS key and registered ProxyTarget(s) will fail to connect as they lack access to
kms:Decrypt
using the encrypted key.When this occurs the following can be observed in the DatabaseProxy logs but only when
debugLogging
is settrue
.This is my first CDK PR, i've run the following:
Closes #28850
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license