docs(s3): better explain behavior of BUCKET_OWNER_PREFERRED #28867
Conversation
Update the enum ObjectOwnership to be more explicit.
github-actions
bot
added
p2
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
jramacha
changed the title
| @@ -1291,7 +1291,7 @@ export enum ObjectOwnership { | |||
| */ | |||
| BUCKET_OWNER_PREFERRED = 'BucketOwnerPreferred', | |||
| /** | |||
| * The uploading account will own the object. | |||
| * The bucket owner will own the object if the object is uploaded with the bucket-owner-full-control canned ACL. Without this setting and canned ACL, the object is uploaded and remains owned by the uploading account. | |||
There was a problem hiding this comment.
The issue mentions BUCKET_OWNER_PREFERRED, but we are updating OBJECT_WRITER's docstring here. Did you mean to update BUCKET_OWNER_PREFERRED instead?
There was a problem hiding this comment.
Oops.. Thanks for catching it ,I'll update it.
kaizencc
changed the title
Update the comment based on the feedback.
kaizencc
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Update the enum ObjectOwnership docs to be more explicit. As mentioned [here](aws#28866) the documentation is not explicit but in S3 [documentation](https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html) its explicit. We had discussed with Kaizen in [issue](aws#28866) before entering this PR/Issue. Closes aws#28866 . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Update the enum ObjectOwnership docs to be more explicit. As mentioned [here](#28866) the documentation is not explicit but in S3 [documentation](https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html) its explicit. We had discussed with Kaizen in [issue](#28866) before entering this PR/Issue. Closes #28866 . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Update the enum ObjectOwnership docs to be more explicit. As mentioned here the documentation is not explicit but in S3 documentation its explicit. We had discussed with Kaizen in issue before entering this PR/Issue.
Closes #28866 .
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license