fix(ec2): deploying an isolated subnet fails when ipv6AssignAddressOnCreation is set to true

[badmintoncryer]

This PR resolves the issue where deploying an isolated subnet with ipv6AssignAddressOnCreation enabled fails.

example

new Vpc(stack, 'TheVPC', {
        ipProtocol: IpProtocol.DUAL_STACK,
        subnetConfiguration: [
          {
            subnetType: testData.subnetType,
            name: 'subnetName',
            ipv6AssignAddressOnCreation: true,
          },
        ],
      });

error

6:39:48 PM | CREATE_FAILED        | AWS::EC2::Subnet                      | vpcisolatedSubnet1Subnet06BBE51F
Template error: Fn::Select  cannot select nonexistent value at index 0

solution

A dependency on the CidrBlock has been added as discussed in issue.

      (this.isolatedSubnets as PrivateSubnet[]).forEach((isolatedSubnet) => {
        if (this.ipv6CidrBlock !== undefined) {
          isolatedSubnet.node.addDependency(this.ipv6CidrBlock);
        }
      });

Question

This modification results in the failure of existing integration tests.
I don't consider this change to be a breaking one, so I went ahead and updated the snapshot. Is that okay?

  CHANGED    aws-ec2/test/integ.vpc-dual-stack-ec2 0.776s
      Resources
[~] AWS::EC2::Subnet Ip6VpcDualStackPrivateSubnet1Subnet842B7F4C 
 └─ [+] DependsOn
     └─ ["Ip6VpcDualStackipv6cidr40BE830A"]
[~] AWS::EC2::RouteTable Ip6VpcDualStackPrivateSubnet1RouteTable5326D239 
 └─ [+] DependsOn
     └─ ["Ip6VpcDualStackipv6cidr40BE830A"]
[~] AWS::EC2::SubnetRouteTableAssociation Ip6VpcDualStackPrivateSubnet1RouteTableAssociationF1C10B6A 
 └─ [+] DependsOn
     └─ ["Ip6VpcDualStackipv6cidr40BE830A"]
[~] AWS::EC2::Subnet Ip6VpcDualStackPrivateSubnet2SubnetEB493489 
 └─ [+] DependsOn
     └─ ["Ip6VpcDualStackipv6cidr40BE830A"]
[~] AWS::EC2::RouteTable Ip6VpcDualStackPrivateSubnet2RouteTable56BF517C 
 └─ [+] DependsOn
     └─ ["Ip6VpcDualStackipv6cidr40BE830A"]
[~] AWS::EC2::SubnetRouteTableAssociation Ip6VpcDualStackPrivateSubnet2RouteTableAssociationD37A3D3D 
 └─ [+] DependsOn
     └─ ["Ip6VpcDualStackipv6cidr40BE830A"]

Closes #28843

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[ConnorRobertson]

Yeah I think this looks good to me. The added dependency shouldn't be a breaking change in this case I think as well.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 039f305
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).