Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cloudformation-include): outputs resource id misspelled $Ouputs #28916

Merged
merged 5 commits into from
Jan 30, 2024
Merged

chore(cloudformation-include): outputs resource id misspelled $Ouputs #28916

merged 5 commits into from
Jan 30, 2024

Conversation

ayush-shah-1501
Copy link
Contributor

@ayush-shah-1501 ayush-shah-1501 commented Jan 29, 2024 •
edited
Loading

Fix the misspelled of outputs resource id $Ouputs.

Closes #28908

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Jan 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 29, 2024 16:51
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 and removed p2 labels Jan 29, 2024
@ayush-shah-1501 ayush-shah-1501 marked this pull request as ready for review January 29, 2024 17:22
kaizencc
kaizencc previously approved these changes Jan 30, 2024
View reviewed changes
@mergify mergify bot dismissed kaizencc’s stale review January 30, 2024 16:25

Pull request has been modified.

kaizencc
kaizencc approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let mergify do its thing, if you make changes to the PR it invalidates review

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ayush-shah-1501
Copy link
Contributor Author

Let mergify do its thing, if you make changes to the PR it invalidates review

@kaizencc Can you please help me with this error: Mergify doesn't have permission to update

@ayush-shah-1501
Copy link
Contributor Author

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024

refresh

✅ Pull request refreshed

@kaizencc
Copy link
Contributor

@ayush-shah-1501 we're having some trouble with permissioning, but we'll get this in eventually

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fff5e12
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a441d37 into aws:main Jan 30, 2024
10 checks passed
@ayush-shah-1501 ayush-shah-1501 deleted the fix-output-misspel branch January 31, 2024 03:28
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
SankyRed pushed a commit that referenced this pull request Feb 8, 2024
@ayush-shah-1501 @SankyRed
chore(cloudformation-include): outputs resource id misspelled $Ouputs (…
c148af0 
…#28916)

Fix the misspelled of outputs resource id $Ouputs.

Closes #28908 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees
No one assigned
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudformation-include: outputs resource id misspelled $Ouputs
3 participants
@ayush-shah-1501 @kaizencc @aws-cdk-automation