feat(type-safe-api): add metadata option to typescript codegen for esm compatible code #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 31e0670. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
cogwirrel
force-pushed
the
feat/tsapi-esm-metadata
branch
2 times, most recently
from
87a9f12 to
58612a9
Compare
…m compatible code Adds an option to the typescript generators to emit esm compatible code (eg imports ending with .js).
cogwirrel
force-pushed
the
feat/tsapi-esm-metadata
branch
from
58612a9 to
bb1116d
Compare
agdimech
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to the typescript generators to emit esm compatible code (eg imports ending with .js).
Also fixes a bug where if the generate script was invoked with an
outputPathother than the working directory, it would always overwrite files as it would check the file exists relative to the working directory rather than theoutputPath.