Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-s3): use member xmlname if applicable #2835

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Sep 27, 2021

Issue

Resolves #1814
Resolves #2445

Description

When the payload member has xmlname trait, we need to use the xmlname value for the member rather than the target shape's name.

Cross validate the diffs with the V2 SDK.

Smithy doc: https://awslabs.github.io/smithy/1.0/spec/core/xml-traits.html#xmlname-trait


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@adamthom-amzn adamthom-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need protocol test updates to make sure that these don't regress/aren't a problem in future SDKs?

@codecov-commenter
Copy link

Codecov Report

Merging #2835 (1bfad22) into main (033a4d8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2835   +/-   ##
=======================================
  Coverage   60.41%   60.42%           
=======================================
  Files         554      554           
  Lines       28885    28886    +1     
  Branches     7072     7072           
=======================================
+ Hits        17452    17453    +1     
  Misses      11433    11433           
Impacted Files Coverage Δ
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 62.89% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033a4d8...1bfad22. Read the comment docs.

@AllanZhengYP
Copy link
Contributor Author

AllanZhengYP commented Sep 27, 2021

Thank you @adamthom-amzn,

I find the xml validator was incorrect as it doesn't validate the outmost node name:

const unequalParts: any = compareEquivalentXmlBodies(bodyString, r.body.toString());

I will put the fix in a separate PR.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants