Can't use errors.Is() and errors.As() with s3's ListParts()

[F21]

Confirm by changing [ ] to [x] below to ensure that it's a bug:

• I've gone though the API reference
• I've checked AWS Forums and StackOverflow for answers
• I've searched for previous similar issues and didn't find any solution

Describe the bug
When using ListParts to list the parts of a multipart upload, if the upload does not exist, a NoSuchKey error is returned. This is evident when printing the error: https response error StatusCode: 404, RequestID: tx00000000000000000095a-00608116e2-1014-default, HostID: 1014-default-default, api error NoSuchKey: UnknownError.

The problem is that the types.NoSuchKey error is not in the error chain, so it is impossible to use error.Is() or errors.As() to unwrapped the error chain into a types.NoSuchKey.

Version of AWS SDK for Go?
Example: v1.3.3

Version of Go (go version)?
1.16.2

To Reproduce (observed behavior)

_, err := c.s3Client.ListParts(ctx, &s3.ListPartsInput{
  Bucket:     aws.String("mybucket"),
  Key:          aws.String("invalidkey"),
  UploadId: aws.String("uploadID"),
  MaxParts: 10000,
})

if err != nil {
  if errors.Is(err, &types.NoSuchKey{}){
    fmt.Println("Is NoSuchKey error")
  }
}

Expected behavior
Is NoSuchKey error should be printed.

[skotambkar]

Thanks for letting us know. S3 does not model NoSuchKey as an error for that operation and thus the error isn't deserialized into that type. Transferring this issue to aws-sdk repo as this affects all sdks.

[vudh1]

P71069218

[RanVaknin]

Hi,

S3 now has proper error modeling for non existent upload, the API now returns a NoSuchUpload which you can reliably error handle on.

<?xml version="1.0" encoding="UTF-8"?>
<Error>
  <Code>NoSuchUpload</Code>
  <Message>The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.</Message>
  <UploadId>uploadID</UploadId>
  <RequestId>REDACTED</RequestId>
  <HostId>REDACTED</HostId>
</Error>

Thanks again,
Ran~

[github-actions]

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.