-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot a simulation of the congestion controller #468
Conversation
…ze of the congestion window
Are all of the functions available in https://crates.io/crates/libm? We might be able to include that when we're in no_std. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the actual snap file anywhere. Did you forget to commit that?
…wslabs/s2n-quic into WesleyRosenblum/congestionplot
Codecov Report
@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 62.98% 63.02% +0.03%
==========================================
Files 205 206 +1
Lines 8291 8327 +36
Branches 2130 2134 +4
==========================================
+ Hits 5222 5248 +26
- Misses 1676 1683 +7
- Partials 1393 1396 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
In light of #458, which could have been easily detected with a visual representation of the congestion window, this change introduces a plot of congestion window over time for a particular simulation of the congestion controller. For now, there is just one simple simulation where in each round the full congestion window is sent and acked, but we can add more simulations in the future. In addition, I've added a snapshot test to verify nothing has changed with the output of the congestion controller.
As can be seen in the plot, the congestion window is growing linearly, when it should be growing exponentially while in slow start (see #458)

Here is another simulation, this time with Loss experienced at 3MB:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.