wildcard-file: fix crash when flow-controlled driver gets destroyed #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, directory_monitors were stopped and destroyed in the free() method of WildcardSourceDriver. This can cause a crash because flow-controlled sources may retain references to their driver (through their ack tracker), and the last unref() call may be executed from a source thread (non-main thread). Stopping directory monitors in the deinit() method fixes this issue, and it also fixes another issue where the driver would register a new superfluous monitor for the same directory each config revert. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
alltilla
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
directory_monitorswere stopped and destroyed in thefree()method ofWildcardSourceDriver.This can cause a crash because flow-controlled sources may retain references to their driver (through their ack tracker), and the last
unref()call may be executed from a source thread (non-main thread).Stopping directory monitors in the
deinit()method fixes this issue, and it also fixes another issue where the driver would register a new superfluous monitor for the same directory each config revert.Fixes syslog-ng/syslog-ng#5085 and the mentioned monitor reregistration issue