transport-stack: fix shutdown #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log_transport_free() is responsible for shutdown, which requires an open fd. Signed-off-by: László Várady <[email protected]>
This tries to send out a close notify before destroying the transport. > The shutdown procedure consists of 2 steps: the sending of the > "close notify" shutdown alert and the reception of the peer's > "close notify" shutdown alert. > > According to the TLS standard, it is acceptable for an application to > only send its shutdown alert and then close the underlying connection > without waiting for the peer's response (this way resources can be saved, > as the process can already terminate or serve another connection). Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
bazsi
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_transport_free()is responsible for shutdown, which requires an open fd.