-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filterx keys function #435
Conversation
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment, also I feel increasingly that the function support code needs to be improved, there's still to much boiler plate around creating a function and writing its argument parsing.
In a similar vein, I'd want to turn FilterXFunction as an expr into a FilterXCall, which operates on various function types, e.g. simple and generator and generic, each with more supporting framework to help facilitate the writing of those functions.
But that's just a side note, this one can go in even with the extra argument check. I'd appreciate the removal of all similar checks as a separate PR though.
@bshifter Can you please create a newsfile entry for this in another PR, thanks! |
example: