Filterx unmarshal does not cause variables to be dirty #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
filterx-unmarshal-does-not-cause-variables-to-be-dirty
branch
2 times, most recently
from
e2c6b41 to
fd3ecd3
Compare
bazsi
force-pushed
the
filterx-unmarshal-does-not-cause-variables-to-be-dirty
branch
from
fd3ecd3 to
368b81f
Compare
…in addition to is_floating Signed-off-by: Balazs Scheidler <[email protected]>
…instances We do not really support message contexts (as does the original filter language and templates), so remove that support. This makes it simpler to initialize FilterXEvalContext as well as we do not have to manage the LogMessage array separately. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…s to the front Signed-off-by: Balazs Scheidler <[email protected]>
It does not really free @self, so it only clears up allocations within an existing instance, these are usually called *_clear() functions. Signed-off-by: Balazs Scheidler <[email protected]>
…ayer Previously the type enum was only used during the initialization of FilterXExprVariable which was then translated to a set of booleans at the variable layer. Also clean up naming a bit. Signed-off-by: Balazs Scheidler <[email protected]>
If we pull in a variable from the message and we need to unmarshal it (e.g. turn FilterXMessageValue to a more specific type like FilterXString or FilterXJSON), do not consider that a change of that variable. Changing it in-place, or assignment of a new value should be remain to be a change. Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-unmarshal-does-not-cause-variables-to-be-dirty
branch
from
368b81f to
795ba18
Compare
OverOrion
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch improves "changed" detection of variables, by not considering variables to be changed if all we do is unmarshal them.
It comes with a set of preparatory steps/refactors. Some of these can be considered unrelated, but I didn't want to open PRs separately.