Filterx allow stack based integer wrappers #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
filterx-allow-stack-based-integer-wrappers
branch
from
dd0298f to
6fbb60c
Compare
alltilla
previously approved these changes
Feb 5, 2025
We are encapsulating a GenericNumber instance in our integer/boolean/double objects, basically having two layers of encapsulation. I attempted to remove one of these but it was a lot more difficult and would require API changes, so for now I was satisfied with inlining the integer paths, which is exercised whenever we are using an integer in filterx (e.g. iterating over a list in parse_csv()). Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
alltilla
force-pushed
the
filterx-allow-stack-based-integer-wrappers
branch
from
6fbb60c to
9483eb1
Compare
|
Rebased to main. |
alltilla
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #470 but this time with integer objects. It seems that we have a parse_csv() invocation with over a 100 integer
fields, so the integer cache does not cover it and I don't want to increase that cache infinitely.
This should go in after #470