vars(): add exclude_msg_values parameter
#505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
previously approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Looks good. I was thinking if we needed to exclude non declared variables how would that look?
What if the option was exclude_message_values or something. This is quite ugly as a name, my point is that we probably only need to include declared, floating values
|
Let's go with |
MrAnno
force-pushed
the
vars-floating-only
branch
2 times, most recently
from
7cb6b12 to
0977b35
Compare
|
This looks good, albeit we would need to rebase it against main as #504 was merged. |
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
vars-floating-only
branch
from
0977b35 to
72423af
Compare
bazsi
approved these changes
Feb 13, 2025
MrAnno
changed the title
vars(): add floating_only parametervars(): add exclude_message_values parameter
alltilla
approved these changes
Feb 13, 2025
MrAnno
changed the title
vars(): add exclude_message_values parametervars(): add exclude_msg_values parameter
fekete-robert
pushed a commit
to axoflow/axosyslog-core-docs
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depens on #504
Note:
vars()lies a little, because it formats both floating and message-tied variables, but NOT ALL message variables as they might have never appeared inside FilterX.