rename the table_name parameter of the azure monitor destination #531
Conversation
* rename the table_name parameter to stream_name
to match the actual behavior of the ingestion process
* eliminate the two frontend blocks as they have become
redundant
Signed-off-by: Janos Szigetvari <[email protected]>
| @@ -49,47 +52,3 @@ block destination _azure_monitor_internal( | |||
| `__VARARGS__` | |||
| ); | |||
| }; | |||
|
|
|||
| block destination azure_monitor_builtin( | |||
There was a problem hiding this comment.
Please keep the old destinations for a few more releases because this would be a breaking change otherwise.
We can deprecate the old ones and document only the new one, but let's keep them here for 2 more releases.
There was a problem hiding this comment.
(I'm sure nobody started using it, so the whole deprecation ceremony is useless, but due to how we version AxoSyslog releases, this is the cleanest and fair way.)
There was a problem hiding this comment.
Please keep the old destinations for a few more releases because this would be a breaking change otherwise. We can deprecate the old ones and document only the new one, but let's keep them here for 2 more releases.
Okay, so azure_monitor_builtin() and azure_monitor_custom() should remain, but what about the table_name paramter? Should it be aliased to stream_name along the same reasoning?
There was a problem hiding this comment.
We can create aliases as long as they won't break existing configurations, but I think it does not worth the extra efforts. As you see fit.
bultin() and custom() are now considered deprecated, we can remove them in 4.12.0 completely.
The
table_nameparameter of theazure-monitordestination is actually referring to the stream name in the DCR, and not the table the logs end up getting written to. The actual destination table name is referenced in the DCR.For this reason the
table_nameparameter should be rename tostream_name.