Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build dependencies not added to the rendered BUILD.bazel #3227

Open
bakjos opened this issue Jan 31, 2025 · 0 comments
Open

Build dependencies not added to the rendered BUILD.bazel #3227

bakjos opened this issue Jan 31, 2025 · 0 comments

Comments

@bakjos
Copy link

bakjos commented Jan 31, 2025

When using build dependencies inside a Cargo.toml in a workspace, the rendered BUILD.bazel in crates_index does not include the build dependencies

I have the following build dependencies

[build-dependencies]
xmltree = "0.6"
phf_codegen = "0.7.24"

These 2 dependencies are not added to the resulting bazel file, generating the error no such target '@@crate_index//:phf_codegen-0.7.24': target 'phf_codegen-0.7.24' not declared in package

It was working well in 0.56.0 and started failing in 0.57.0

After debugging I realized the version 0.5.6 keeps the build_deps with full names "phf_codegen": Label("@crate_index__phf_codegen-0.7.24//:phf_codegen") however the new versions include them as "phf_codegen": Label("//:phf_codegen-0.7.24"), but the alias is not created in the main BUILD.bazel file. The change was introduced here 5e90483#diff-a165d4fcf7bc187750bb12572611029ff1522d224f1b4cc96483e6184e254c52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant