V1.0.0 fixes #167

aafshinfard · 2021-04-01T07:16:36Z

No description provided.

Now to iterate over a `dict`, the only acceptable way is two call `.items()`

temporarily disabling pylint as it has an active bug for two lines: pylint-dev/pylint#3675

aafshinfard · 2021-04-01T07:56:58Z

Three pylint errors due to a pylint active unresolved bug:
pylint-dev/pylint#3675
I fixed this by temporarily disabling the error codes for the lines

+
a warning and
a recommendation at line 2435 (I am not sure I fixed it correctly, please double-check. It suggested that we use generators instead)

lcoombe · 2021-04-01T15:42:59Z

Looks good to me Amirhossein!
The generator expression fix looks fine to me - I find those really cool and useful in that sort of context!

aafshinfard added 6 commits March 31, 2021 23:51

happy pylint (newly added linter)

a51a9ea

Now to iterate over a `dict`, the only acceptable way is two call `.items()`

disable pylint for two lines due to bugs

8abcb7b

temporarily disabling pylint as it has an active bug for two lines: pylint-dev/pylint#3675

fix typo

cbe4951

happy pylint warnings

92eafe0

Happy pylint recoms

d2d8daf

fix typo

7cf847c

aafshinfard added the bug Something isn't working label Apr 1, 2021

aafshinfard self-assigned this Apr 1, 2021

aafshinfard requested review from jwcodee and lcoombe April 1, 2021 07:52

lcoombe approved these changes Apr 1, 2021

View reviewed changes

aafshinfard merged commit fde0cae into master Apr 1, 2021

aafshinfard deleted the v1.0.0-fixes branch July 20, 2022 19:15

Provide feedback