add-favicon: implictly include favicon at layout template #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
reviewed
Nov 16, 2023
| @@ -22,6 +22,8 @@ | |||
| {{/if}} | |||
| <link rel="stylesheet" href="{{ basePath }}/dashboard.css"> | |||
| <script>hljs.initHighlightingOnLoad();</script> | |||
| <!-- Favicon --> | |||
| <link rel="shortcut icon" href="{{ basePath }}/favicon.ico" type="image/x-icon"> | |||
There was a problem hiding this comment.
what about passing it as a new option like customCssPath, also this should be optional, only if customFavicon is provided:
{{#if customFavicon}}
<link rel="shortcut icon" href="{{ customFavicon }}" type="image/x-icon">
{{/if}}
There was a problem hiding this comment.
Hi, I think I dont understand the comment, why having something like a custom favicon?
This PR intention is just showing the one that is already present at /public/favicon.ico but its not used.
There was a problem hiding this comment.
hey @ivnnv I tried your change locally, lgtm thank you
roggervalf
approved these changes
Feb 8, 2024
beequeueci
pushed a commit
that referenced
this pull request
Feb 8, 2024
### [4.1.1](v4.1.0...v4.1.1) (2024-02-08) ### Bug Fixes * **layouts:** include favicon at layout template ([#668](#668)) ([a107ad9](a107ad9))
|
🎉 This PR is included in version 4.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding the favicon as its not showing