Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpdstats plugin needs updating to work with python-mpd2 2.0.0 #3798

Closed
smcv opened this issue Nov 24, 2020 · 1 comment · Fixed by #3825
Closed

mpdstats plugin needs updating to work with python-mpd2 2.0.0 #3798

smcv opened this issue Nov 24, 2020 · 1 comment · Fixed by #3825
Labels
bug bugs that are confirmed and actionable

Comments

@smcv
Copy link

smcv commented Nov 24, 2020

(Sorry, this is just from source code inspection and a search of dependent packages in Debian, rather than a crash that I've genuinely reproduced - I don't currently use beets myself, although I keep meaning to try it.)

https://github.com/Mic92/python-mpd2 version 2.0.0 dropped support for the use_unicode parameter to the MPDClient constructor. This parameter doesn't do anything in Python 3, which always behaves like use_unicode=True. It was important in Python 2.

In Debian's python3-mpd package I've added back compatibility with the use_unicode parameter for now (see Mic92/python-mpd2#142) but I don't know whether that will be accepted upstream.

If beets only supports Python 3, dropping the parameter should be a sufficient fix: replace MPDClient(use_unicode=True) with MPDClient().

If it still supports Python 2, something similar to multani/sonata#116 should work.

@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Nov 24, 2020
@sampsyo
Copy link
Member

sampsyo commented Nov 24, 2020

Thank you for the report, traceback or no! A simple check like in Sonata should do well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants