Dictionary, set, and frozenset implementations have duplicate key problems

[swenson]

Since JavaScript is pretty lax about equality, we get unexpected behavior when mixing types in dictionaries and sets:

d = {}
d['1'] = 123
d[1] = 456
print(d)

gives {'1': 456} for example, and

print(set([1, '1']))

gives {'1'}.

I think we may have to roll our own hash table implementation to fix this.

[rkrp]

I would like to work on this one 😄

I have forked and cloned the source. Trying out Batavia locally. I am going through the documentation right now. Please let me know how to proceed further.

[swenson]

Oh, sorry @rkrp -- I think I merged the fix for this the other day and forgot to close this issue! :( #288

[swenson]

There are lots of other things to work on. I recommend checking out #47 and #46 for example.

[rkrp]

@swenson Oh. That's okay.

But, #47 and #46 has a first-timers-only tag. I have sent a handful of PRs to other projects (mostly small stuff) which has been accepted and merged. So, I am technically not a first timer. Would it be okay for me to be working on these issues?

[swenson]

Yes. I think first-timers-only is meant for first-timers-only to this project, as they are meant to gently introduce you to the codebase :)
On Oct 15, 2016 03:55, Krishna Ram Prakash R [email protected] wrote:@swenson Oh. That's okay.

But, #47 and #46 has a first-timers-only tag. I have sent a handful of PRs to other projects (mostly small stuff) which has been accepted and merged. So, I am technically not a first timer. Would it be okay for me to be working on these issues?

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.