This repository has been archived by the owner on May 31, 2020. It is now read-only.
Completed implementation of float() builtin - all test cases now passing. #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added python-compliant error handling support for passing complex, byte and bytearray objects to the float builtin function. Some of these types threw non-standard messages in python and this functionality has been implemented in Batavia.
Problem
Error handling for objects of type complex, bytes and bytearray when passed to the builtin float() did not conform to the CPython implementation (generally threw ValueErrors instead of the correct TypeErrors). These issues were the causes of all remaining test failures in the float() Batavia implementation.
Issues
Contributes to fixing #47.
PR Checklist: