This repository has been archived by the owner on May 31, 2020. It is now read-only.
fixed implementation of hex() builtin - all tests pass #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Completed the implementation of hex for all input types. Had to introduce a dependency to the implementation (BigNumber - previously used in the implementation of the Integer type) due to the differences in how Python and Javascript handle large numbers. Unsupported types are now handled with Python-compliant errors.
Problem
The builtin function hex was failing for input from every builtin type, including Bool and Int, which it is supposed to support. Other types were failing with incorrect error types.
Fixes
Contributes to fixing #47
PR Checklist: