Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping the docs current #503

Closed
effigies opened this issue Sep 20, 2019 · 5 comments · Fixed by #598
Closed

Keeping the docs current #503

effigies opened this issue Sep 20, 2019 · 5 comments · Fixed by #598
Labels

Comments

@effigies
Copy link
Collaborator

We're currently manually pushing the docs to https://bids-standard.github.io/pybids/, which is easy to forget, and the docs are currently out-of-date (0.9). It would be good to make an explicit process to update them or set up something automatic like ReadTheDocs.

ReadTheDocs also has the advantage of keeping old versions around, which might be useful for reference as the API changes.

@tyarkoni
Copy link
Collaborator

Should be easy enough; to push the docs I just checkout the gh-pages branch and run install_docs.sh. So I think if you just add that to CI, we should be good.

@effigies
Copy link
Collaborator Author

I assume only on tag builds?

@effigies
Copy link
Collaborator Author

@tyarkoni Just FYI the docs don't build with modern Sphinx. We should add a doc extra (and/or doc-requirements.txt) with the required versions so that script can create a venv and build.

@tyarkoni
Copy link
Collaborator

Will take a look... might be better to fix whatever's failing so we're not stuck with old sphinx versions.

@sappelhoff
Copy link
Member

might be better to fix whatever's failing so we're not stuck with old sphinx versions

I think the m2r package is the main culprit (see: scikit-hep/pyhf#818). It breaks when it's being used as a sphinx extension (like in our case).

A fix could be to call m2r in the docs build process, rather than using it as a sphinx extension. Should be simple enough because as it seems to me, only CHANGELOG.md needs to be converted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants