Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical Clustering: smaller ControlArea #7035

Open
ajdapretnar opened this issue Feb 19, 2025 · 1 comment · May be fixed by #7040
Open

Hierarchical Clustering: smaller ControlArea #7035

ajdapretnar opened this issue Feb 19, 2025 · 1 comment · May be fixed by #7040
Labels
bug report Bug is reported by user, not yet confirmed by the core team

Comments

@ajdapretnar
Copy link
Contributor

ajdapretnar commented Feb 19, 2025

What's wrong?
Hierarchical Clustering has a very wide ControlArea, depending on the initial input data.
ControlArea could be smaller (narrower).

How can we reproduce the problem?

  1. File (iris) - Distances - Hierarchical Clustering. Everything ok.
  2. New Orange instance. Datasets (HDI) - Distances - Hierarchical Clustering. ControlArea very wide.
    Note that when I open HDI after iris, ControlArea is ok. So it depends on initialization.

Compare below:
Iris
Image
HDI
Image

What's your environment?

  • Operating system: OSX
  • Orange version: 3.38.1
  • How you installed Orange: pip
@ajdapretnar ajdapretnar added the bug report Bug is reported by user, not yet confirmed by the core team label Feb 19, 2025
@janezd
Copy link
Contributor

janezd commented Feb 19, 2025

Note to whomever will be resolving this: I think that the width of Annotations and Color by combos should be reduced by setting their horizontal size policy to Ignored. This seems to make them occupy all available space but not more.

The problem with this solution -- or any other that limits the width of the (closed) combo -- is that the popup will be just as wide as combo. The popup seems to ignore its size policy and even directly setting its width doesn't work. The only place where the width can be extended is in the showPopup method. Setting a different width at https://github.com/biolab/orange-widget-base/blob/master/orangewidget/utils/combobox.py#L276 works. To determine the proper width we could check the size policy and -- if needed -- observe the width provided by sizeHintFromColumn(0).

@janezd janezd linked a pull request Feb 21, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug is reported by user, not yet confirmed by the core team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants