Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better output in failed tests #645

Closed
real-or-random opened this issue Jul 2, 2019 · 0 comments · Fixed by #685
Closed

Better output in failed tests #645

real-or-random opened this issue Jul 2, 2019 · 0 comments · Fixed by #685

Comments

@real-or-random
Copy link
Contributor

real-or-random commented Jul 2, 2019

When a test fails, it currently outputs only the failed assertion (with file and line) to stderr. The seed is output to stdout only. Moreover, neither stdout nor stderr are output on make check. Instead, the stderr is written to ./test-suite.log

As a consequence, a non-reproducible failure on Travis is somewhat useless to us because we just see the FAIL but we have no idea what failed because we don't see the contents of the log file. (This just happened downstream in secp256k1-zkp). A similar issue was the failed PR build on a Fedora build server, which contained only stderr #558 (comment) and thus we didn't get the seed.

We should probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant