Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Inspector::call retrun type #872

Closed
mattsse opened this issue Nov 20, 2023 · 1 comment
Closed

Clarify Inspector::call retrun type #872

mattsse opened this issue Nov 20, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation refactor Refactor of the code

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 20, 2023

not obvious what the range of the return type represents

/// Called whenever a call to a contract is about to start.
///
/// InstructionResulting anything other than [crate::interpreter::InstructionResult::Continue] overrides the result of the call.
#[inline]
fn call(
&mut self,
context: &mut EvmContext<'_, DB>,
inputs: &mut CallInputs,
) -> Option<(InterpreterResult, Range<usize>)> {

ref paradigmxyz/reth#5502

@rakita rakita added documentation Improvements or additions to documentation refactor Refactor of the code labels Dec 25, 2023
@rakita
Copy link
Member

rakita commented Jan 30, 2024

Done by adding structs

@rakita rakita closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactor Refactor of the code
Projects
None yet
Development

No branches or pull requests

2 participants