Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: optional nonce check (#1195)" #1212

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

rakita
Copy link
Member

@rakita rakita commented Mar 19, 2024

This reverts commit fe841be.

PR: #1195

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Valgrind Results:

==4042== Cachegrind, a cache and branch-prediction profiler
==4042== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4042== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4042== Command: target/release/snailtracer
==4042== 
--4042-- warning: L3 cache found, using its data for the LL simulation.
Snailtracer Host+Interpreter benchmark (2.1s) ...            not enough samples
==4042== 
==4042== I   refs:      463,579,569
==4042== I1  misses:          5,108
==4042== LLi misses:          2,990
==4042== I1  miss rate:        0.00%
==4042== LLi miss rate:        0.00%
==4042== 
==4042== D   refs:      237,187,863  (160,464,946 rd   + 76,722,917 wr)
==4042== D1  misses:        322,941  (    183,100 rd   +    139,841 wr)
==4042== LLd misses:        137,576  (      4,065 rd   +    133,511 wr)
==4042== D1  miss rate:         0.1% (        0.1%     +        0.2%  )
==4042== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4042== 
==4042== LL refs:           328,049  (    188,208 rd   +    139,841 wr)
==4042== LL misses:         140,566  (      7,055 rd   +    133,511 wr)
==4042== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 713ed4f into main Mar 19, 2024
25 checks passed
@rakita rakita deleted the revert_nonce_check_cfg branch April 1, 2024 12:11
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
* Revert "feat: optional nonce check (bluealloy#1195)"

This reverts commit fe841be.

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant