Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call Handler::clear #2091

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: call Handler::clear #2091

merged 1 commit into from
Feb 18, 2025

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Feb 18, 2025

Right now this is defined but never called which results in tx cached values not being reset for op

Copy link

codspeed-hq bot commented Feb 18, 2025

CodSpeed Performance Report

Merging #2091 will not alter performance

Comparing klkvr/clear (a8a9893) with main (cd6ebd8)

Summary

✅ 8 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would refactor it slightly, so clear is called every time even if a error happens

But for now, lets merge it as it fixes the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants