Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blst): Fix wrong constants value and usage #2102

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

rakita
Copy link
Member

@rakita rakita commented Feb 20, 2025

A lot of bugs introduced in #2085

Fixing them and enabling prague statetest in CI

Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #2102 will degrade performances by 2.47%

Comparing rakita/blst_fix_const (1f8bac2) with main (eeccdc3)

Summary

❌ 1 regressions
✅ 7 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
precompile bench | ecrecover precompile 197.4 µs 202.4 µs -2.47%

@rakita rakita merged commit ac939f6 into main Feb 20, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant