Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix wrong comment & remove useless impl #2105

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

jackwener
Copy link
Contributor

@jackwener jackwener commented Feb 22, 2025

When I read the source code of revm, I find some wrong comment. So I fix them.

  • fix wrong comment
  • remove useless impl

@jackwener jackwener changed the title chore: fix wrong comment & remove useless struct chore: simplify hash()/eq() & fix wrong comment & remove useless struct Feb 22, 2025
@jackwener jackwener changed the title chore: simplify hash()/eq() & fix wrong comment & remove useless struct chore: simplify hash()/eq() & fix wrong comment & remove useless impl Feb 22, 2025
Copy link

codspeed-hq bot commented Feb 22, 2025

CodSpeed Performance Report

Merging #2105 will improve performances by 4.34%

Comparing jackwener:opt (eb1bcce) with main (03e3d8d)

Summary

⚡ 1 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
precompile bench | ecrecover precompile 202.5 µs 194.1 µs +4.34%

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, this lgtm

smol nit

@jackwener
Copy link
Contributor Author

Thanks @mattsse review

@jackwener jackwener requested review from mattsse February 23, 2025 06:14
When I read the source code of revm, I find some wrong comment. So I fix them.
@jackwener jackwener changed the title chore: simplify hash()/eq() & fix wrong comment & remove useless impl chore: fix wrong comment & remove useless impl Feb 23, 2025
@jackwener
Copy link
Contributor Author

Thank you for your patient review! @mattsse

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@rakita rakita merged commit 01aa4bb into bluealloy:main Feb 24, 2025
28 checks passed
@github-actions github-actions bot mentioned this pull request Feb 21, 2025
@jackwener jackwener deleted the opt branch February 25, 2025 03:38
This was referenced Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants