Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizer mapping messed up in current preview #2071

Closed
PathogenDavid opened this issue Dec 4, 2024 · 2 comments · Fixed by #2158
Closed

Visualizer mapping messed up in current preview #2071

PathogenDavid opened this issue Dec 4, 2024 · 2 comments · Fixed by #2158
Labels
bug Something isn't working critical This is a blocking issue affecting all users
Milestone

Comments

@PathogenDavid
Copy link
Member

PathogenDavid commented Dec 4, 2024

Changing the visualizer doesn't take without restarting the visualizer target. Sometimes closing and reopening fixes.

Also Bonsai.Gui example can't be launched with --no-editor. (Maybe related?)

The crash noted here (but not the main issue) is potentially related to this: bonsai-rx/gui#35

@PathogenDavid PathogenDavid added this to the 2.9 milestone Dec 20, 2024
@PathogenDavid PathogenDavid added bug Something isn't working critical This is a blocking issue affecting all users labels Jan 30, 2025
@glopesdev
Copy link
Member

glopesdev commented Jan 30, 2025

I have not tracked down the exact commit, but I did notice this issue is coming from changes somewhere in the state watch PR #1975.

It doesn't show up in any of the other major 2.9 PRs yet is present in this PR branch alone.

@glopesdev
Copy link
Member

Changing the visualizer doesn't take without restarting the visualizer target. Sometimes closing and reopening fixes.

This was due to incorrect detection of the currently active visualizer at runtime following the refactoring in #1870.

Also Bonsai.Gui example can't be launched with --no-editor. (Maybe related?)

This turned out not to be related, but was a different issue traversing the workflow to set the layout notifications.

Both have been fixed in #2158, so will close this issue on merge. I was not able to reproduce any of this in the rebased workflow watch branch, so I am unsure again what was the exact source of issues in the preview. In the end we may decide to do a preview with the watch feature to see if anyone can reproduce this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical This is a blocking issue affecting all users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants