Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice operator should terminate source sequence after stop condition is reached #930

Closed
glopesdev opened this issue Jun 9, 2022 · 1 comment · Fixed by #1067
Closed

Slice operator should terminate source sequence after stop condition is reached #930

glopesdev opened this issue Jun 9, 2022 · 1 comment · Fixed by #1067
Labels
bug Something isn't working
Milestone
2.7.0

Comments

@glopesdev
Copy link
Member

glopesdev commented Jun 9, 2022 •
edited
Loading

To reproduce, consider the following workflow:

Assuming the Timer is periodic (e.g. 1 second) and Slice has some defined Stop value (e.g. 10), it is surprising to find that the sequence never repeats.
@glopesdev glopesdev added the bug Something isn't working label Jun 9, 2022
@glopesdev glopesdev added this to the 2.7.0 milestone Jun 9, 2022
@glopesdev
Copy link
Member Author

The semantics of the current fix do not match the Take operator. Specifically, OnCompleted should be called as soon as the Stop counter is reached. Also, setting Stop to zero should generate the empty sequence. Finally, it would be great to validate the range of all input parameters to Slice.

@glopesdev glopesdev reopened this Oct 3, 2022
@glopesdev glopesdev mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

Align semantics of Slice operator with Take glopesdev/bonsai
1 participant
@glopesdev