Improve consistency of visualizer context menu #2158
+51
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
force-pushed
the
visualizer-context-menu
branch
from
80bad5a to
e9d4858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few visualizer assignment behaviors were broken by the changes in #1870. Specifically the way the active visualizer is obtained at runtime is no longer valid and needs to change to use the visualizer dialog map.
We also took this opportunity to correct the behavior of the show visualizer context menu to ensure that if the selected visualizer is not visible but the drop down menu item is clicked, the dialog is shown or activated.
Fixes #2071
Fixes #1841