Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU_LINK option does not work anymore #55

Closed
nenomius opened this issue Apr 14, 2020 · 2 comments · Fixed by #120
Closed

ICU_LINK option does not work anymore #55

nenomius opened this issue Apr 14, 2020 · 2 comments · Fixed by #120

Comments

@nenomius
Copy link

ICU_LINK option does not work now, because boost.regex errors build if sees it now.
See boostorg/regex@fc4dc17 and boostorg/regex#89

I would suggest moving ICU finding/configuration into shared file and using it from there like its done for zlib, bzip2, etc, and not doing the same thing in different ways.

@jzmaddock

@leha-bot
Copy link

Finally I can build boost locale in Android NDK without dirty hacks 🥳

@Flamefire
Copy link
Collaborator

@leha-bot Does this mean you tested #120 already and can confirm it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants