[CLOSED] Revert changes to Chrome live preview on mac for sprint 34

[core-ai-bot]

Issue by jasonsanjose
Thursday Nov 14, 2013 at 17:57 GMT
Originally opened as adobe#381

---

Plan B. Requires adobe/brackets#5997.

---

jasonsanjose included the following code: https://github.com/adobe/brackets-shell/pull/381/commits

[core-ai-bot]

Comment by jasonsanjose
Thursday Nov 14, 2013 at 18:26 GMT

---

Assigned @redmunds

[core-ai-bot]

Comment by jasonsanjose
Thursday Nov 14, 2013 at 19:12 GMT

---

@fungl164 if you have some time, could you review these merge commits that were backed out. Specifically I reverted pulls #371, #373 and #379.

I would have liked to see this change. Too bad about #5989.

To restore these changes in the future, you should be able to run git revert -m 1 <SHA of the merge commit TBD>.

[core-ai-bot]

Comment by redmunds
Thursday Nov 14, 2013 at 19:14 GMT

---

Changes look good. Waiting to hear how testing goes.

[core-ai-bot]

Comment by jasonsanjose
Thursday Nov 14, 2013 at 19:20 GMT

---

Can't repro adobe/brackets#5989 with these changes. OSX 10.7.5. Whew.

[core-ai-bot]

Comment by redmunds
Thursday Nov 14, 2013 at 21:44 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by fungl164
Friday Nov 15, 2013 at 13:49 GMT

---

@jasonsanjose at least now we have time to bang on it some more. Perhaps it will make it in time for Christmas as a nice little holiday present. :)