Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] [CEF 2623] Upgrade to latest CEF #10633

Open
core-ai-bot opened this issue Aug 30, 2021 · 6 comments
Open

[CLOSED] [CEF 2623] Upgrade to latest CEF #10633

core-ai-bot opened this issue Aug 30, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by nethip
Wednesday May 11, 2016 at 18:49 GMT
Originally opened as adobe/brackets#12415


With latest CEF, quick open is not showing the results as opacity was set to 0. So removed opacity for .quick-search-container

This is required for updating shell APIt
Related PR :adobe/brackets-shell#544


nethip included the following code: https://github.com/adobe/brackets/pull/12415/commits

@core-ai-bot
Copy link
Member Author

Comment by nethip
Wednesday May 11, 2016 at 18:49 GMT


@swmitra Could you have a look at this PR?

@core-ai-bot
Copy link
Member Author

Comment by nethip
Wednesday May 11, 2016 at 18:59 GMT


@MarcelGerber@ingorichter@peterflynn Would you guys be able to review this PR?

@core-ai-bot
Copy link
Member Author

Comment by Denisov21
Wednesday May 11, 2016 at 19:37 GMT


👍 Good for me!

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Thursday May 12, 2016 at 16:40 GMT


@nethip I have altered this PR by actually fixing the .animation LESS mixin (which was the reason why Quick Open failed), fixing it in other locations, too, and adding opacity: 0 back.

@core-ai-bot
Copy link
Member Author

Comment by nethip
Thursday May 12, 2016 at 16:45 GMT


@MarcelGerber thanks for fixing the actual problem.

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Friday May 13, 2016 at 12:53 GMT


LGTM.
Kudos to@nethip 👍 for this PR and the related PR in brackets-shell.
Great job by@MarcelGerber by providing quick fix for the quick open issue 👍
Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant