[CLOSED] Dialog label same for Quick Open, Go to Line and Go to Definition

[core-ai-bot]

Issue by sagarsane
Sunday Sep 23, 2012 at 20:54 GMT
Originally opened as adobe/brackets#1705

---

Hello,

In search/QuickOpen.js,

the dialogHTML has Strings.CMD_QUICK_OPEN as the label. Should it have a switch case around it and display appropriate Labels (from Strings.CMD_GOTO_LINE and Strings.CMD_GOTO_DEFINITION and Strings.CMD_QUICK_OPEN), based on the prefix ("", ":", "@") that is passed?

I will submit a quick pull request for this if it is okay.

Thanks.
Sagar

[core-ai-bot]

Comment by pthiess
Wednesday Sep 26, 2012 at 22:33 GMT

---

Reviewed - assigning to@njx

[core-ai-bot]

Comment by njx
Thursday Dec 06, 2012 at 22:55 GMT

---

Note: I didn't add this to the "Sprint 18 Bugs" Trello card since it's already accounted for in the "Sprint 18 Pull Requests" card.

[core-ai-bot]

Comment by njx
Tuesday Dec 11, 2012 at 18:36 GMT

---

@sagarsane - we've merged your commits along with our additions. Could you verify this is fixed? Thanks!

[core-ai-bot]

Comment by njx
Wednesday Dec 19, 2012 at 18:31 GMT

---

Closing, confirmed it ourselves.