[CLOSED] FileSystem Implementation (#247)

[core-ai-bot]

Issue by jbalsas
Monday Nov 19, 2012 at 23:31 GMT
Originally opened as adobe/brackets#2158

---

This pull request implements the FileSystem interface described in http://www.w3.org/TR/file-system-api/#the-filesystem-interface and modifies NativeFileSystem.requestNativeFileSystem to return a FileSystem object with a root DirectoryEntry following the specs.

As indicated in #247, it also updates all existing calls to requestNativeFileSystem (tests included) to get the root DirectoryEntry.

This is a dangerous change that could potentially break several extensions so we may want to implement this in a more backward compatible manner. However, I've done a global find in all the extensions listed in the wiki and only brackets-snippets seems to be calling requestNativeFileSystem directly, so it looks less disruptive than I originally thought...

---

jbalsas included the following code: https://github.com/adobe/brackets/pull/2158/commits

[core-ai-bot]

Comment by jasonsanjose
Tuesday Nov 20, 2012 at 18:28 GMT

---

Thanks, Chema. I'm not sure if we can prioritize this for this week. We'll have to take a look again next week. Thanks for your patience.

[core-ai-bot]

Comment by jbalsas
Wednesday Nov 21, 2012 at 08:52 GMT

---

No problem! It's lowprio/cleanup and you guys seem busy enough. No need to hurry on this one ;)

[core-ai-bot]

Comment by jasonsanjose
Wednesday Dec 05, 2012 at 21:23 GMT

---

reviewing

[core-ai-bot]

Comment by jasonsanjose
Wednesday Dec 05, 2012 at 21:44 GMT

---

Initial review complete. Just one minor comment.

[core-ai-bot]

Comment by jbalsas
Thursday Dec 06, 2012 at 11:01 GMT

---

Oops... fixed!

[core-ai-bot]

Comment by jasonsanjose
Thursday Dec 06, 2012 at 18:01 GMT

---

Thanks, Chema! Merging.