Basic HTML property testing for WebAssembly #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import https://gist.github.com/jelmervdl/a4c8b6b92ad88a885e1cbd51c6ad4902 and attach it to CI. NodeJS-14 is failing on trying to use the WebAssembly binary. So we use node-16 independently setup. This paves way for more complicated testing for WebAssembly bindings in the future.
jelmervdl
reviewed
Jun 21, 2022
wasm/node-test.js
Outdated
| const output = service.translate(model, input, options); | ||
|
|
||
| // Get output from std::vector<Response> | ||
| console.log(output.get(0).getTranslatedText()); |
There was a problem hiding this comment.
Should it check the output to be "Hallo Welt!", to detect whether it is producing rubbish or not?
There was a problem hiding this comment.
I'm more in favour of property based testing. Input valid non-empty HTML, did I get valid non-empty HTML translation out, that sort. I expect such stuff to grow if we start exposing a JS library as mentioned in #330. Adding ASSERT_EQUALS will give us pain if compiler etc changes, which often happened in BRT.
jerinphilip
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports
https://gist.github.com/jelmervdl/a4c8b6b92ad88a885e1cbd51c6ad4902 and
attach it to CI. NodeJS-14 is failing on trying to use the WebAssembly
binary. So we use node-16 independently setup. This paves way for more
complicated testing for WebAssembly bindings in the future. It should be possible
to remove minimal builds in favour of closer to WebAssembly tests following this
change.
mozilla/firefox-translations#353 phases out wormhole.
This change removes the
.jsand.wasmwith wormhole from the GitHubrelease done. (This does not edit Mozilla's CircleCI or files, nor attempt to
remove WORMHOLE completely).
This also includes a fix for a
.jsand.wasmrelease broken in #424.GitHub CI code verified to work as intended at at fork
(https://github.com/jerinphilip/bergamot-translator).
Related to: #421, #330