Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow ClickHouse Plugin v1.2.0 is not available on PyPI #75

Closed
bryzgaloff opened this issue Jan 30, 2024 · 5 comments
Closed

Airflow ClickHouse Plugin v1.2.0 is not available on PyPI #75

bryzgaloff opened this issue Jan 30, 2024 · 5 comments

Comments

@bryzgaloff
Copy link
Owner

bryzgaloff commented Jan 30, 2024

A publishing pipeline failed: https://github.com/bryzgaloff/airflow-clickhouse-plugin/actions/runs/7716663176

It requires several adjustments:

@bryzgaloff
Copy link
Owner Author

As a quick fix, you may install it from Test PyPI: the package has already been published there. Use python -m pip install --index-url https://test.pypi.org/simple --extra-index-url https://pypi.org/simple airflow-clickhouse-plugin[common.sql]==1.2.0 to install.

@epikhinm
Copy link
Contributor

Hi @bryzgaloff !
Do you have any plans here? Do you want to release a new version and skip 1.2.0?
Do you need any help with releasing 1.2.0?

@kakvablyat
Copy link

+1

@bryzgaloff
Copy link
Owner Author

Hi everyone, and thank you for waiting for the issue resolution.

There is a problem in the PyPI publishing workflow, and I have not had much time recently to fix this CI pipeline. I am in the process of fixing it. I hope to complete by the end of this week. I have tons of emails and messages, so I am prioritizing this task much higher now.

Here is a quick summary of what has to be fixed:

  • The pipeline has a hardcoded version 1.1.0. But it has to be a pushed git tag.
  • The pipeline should fail if a tag does not follow semver format (1.2.0, not v1.2.0). Maybe PyPI performs the check when a package is uploaded and rejects wrong versioning, but I need to check it on a test upload first.
  • Airflow for PyPI packages tests should be installed with --constraint: otherwise, tests are likely to fail.
  • Ideally, the PyPI tests should be run with all supported versions combinations, but I have not made my final decision if it is required.
  • A preliminary local test should be run before uploading to PyPI.

These steps are intended to avoid publishing a broken package version to PyPI (which is an irreversible action: packages cannot be overwritten even in Test PyPI). A special challenge is that the pipeline itself is not runnable if the package version is already uploaded, which makes testing complicated.

@bryzgaloff
Copy link
Owner Author

Hello everyone! I'm pleased to announce that airflow-clickhouse-plugin==1.2.0 is now available on PyPI: airflow-clickhouse-plugin/1.2.0 🎉

I've applied a quick fix to address the failed workflow steps, ensuring that you don't need to wait any longer for this release. The publishing pipeline has been successfully executed. So, this version has been tested and is fully functional.

I'm closing this issue now as its main objective has been achieved. However, please note that this was a draft version of the pipeline. I'll continue my work in pypi-workflow-fix-#75 branch to implement proper fixes and conduct further testing.

Excitingly, v1.2.0 has been officially published! Happy coding! 😊

Thank you everyone for your patience kindly waiting for the fixes to be applied 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants