Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards compatibility: support old metadata label format during rebase #219

Closed
jromero opened this issue Dec 17, 2019 · 1 comment · Fixed by #220
Closed

Backwards compatibility: support old metadata label format during rebase #219

jromero opened this issue Dec 17, 2019 · 1 comment · Fixed by #220
Assignees
@zmackie
Labels
type/enhancement New feature or request
Milestone
lifecycle-0.6.0

Comments

@jromero
Copy link
Member

jromero commented Dec 17, 2019 •
edited
Loading

Error:

unmarshalling label 'io.buildpacks.lifecycle.metadata': json: cannot unmarshal array into Go struct field LayersMetadata.app of type lifecycle.LayerMetadata

Proposed Solution

  • Lifecycle: Rebase would read data in either format
  • Lifecycle: Rebase would write data in same format as read
  • Lifecycle: Analyze would read data in new format
  • Lifecycle: Export would write data in new format
  • Compatibility:
    • Pack 0.6.0 (using LC as library) CAN rebase app images from Lifecycle 0.5.0
    • Pack 0.5.0 CANNOT rebase app images from Lifecycle 0.6.0
@jromero jromero added the type/enhancement New feature or request label Dec 17, 2019
@ameyer-pivotal ameyer-pivotal mentioned this issue Dec 17, 2019
Merged
@jromero jromero added this to the 0.6.0 milestone Dec 18, 2019
@jromero jromero mentioned this issue Dec 18, 2019
Closed
@jromero jromero modified the milestones: 0.6.0, lifecycle-0.6.0 Jan 16, 2020
@zmackie zmackie self-assigned this Jan 23, 2020
@zmackie
Copy link
Contributor

zmackie commented Jan 23, 2020

Accepted with:

± zm |tag:v0.5.0 ✓| → ./out/pack rebase gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder
0.5.0-builder: Pulling from cncf-buildpacks-ci/pm/issues/219
7ddbc47eeb70: Already exists
c1bbdc448b72: Already exists
8c3b70e39044: Already exists
45d437916d57: Already exists
d8820d47fabc: Already exists
31a97ebb38e0: Already exists
74d9e713303f: Already exists
45bb2bf4beec: Already exists
ac502b30e3c1: Already exists
c12d2737e029: Already exists
2f81c1fd1100: Already exists
d50b42cf8bb1: Already exists
373f713f810b: Already exists
Digest: sha256:0662bb6c703ccedeb3671e94d8c0002d8e6c037c93d7a3500ee1cf34db14fe02
Status: Downloaded newer image for gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder
base-cnb: Pulling from cloudfoundry/run
Digest: sha256:ba9998ae4bb32ab43a7966c537aa1be153092ab0c7536eeef63bcd6336cbd0db
Status: Image is up to date for cloudfoundry/run:base-cnb
Rebasing gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder on run image cloudfoundry/run:base-cnb
*** Images (0cafb9d763ec):
      gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder
Rebased Image: 0cafb9d763ecef22f698aa14ced703f07c4f38202c4f9867acb1b8aeb1832362
Successfully rebased image gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder

  |2.6.3| NY-Floater-15565 in ~/workspace/pack
± zm |tag:v0.5.0 ✓| → ./out/pack rebase gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder
^CERROR: error during connect: Post http://%2Fvar%2Frun%2Fdocker.sock/v1.38/images/create?fromImage=cloudfoundry%2Frun&tag=base-cnb: context canceled
^C

  |2.6.3| NY-Floater-15565 in ~/workspace/pack
± zm |tag:v0.5.0 ✓| → ./out/pack rebase gcr.io/cncf-buildpacks-ci/pm/issues/219:0.6.0-builder
0.6.0-builder: Pulling from cncf-buildpacks-ci/pm/issues/219
5c939e3a4d10: Already exists
c63719cdbe7a: Already exists
19a861ea6baf: Already exists
651c9d2d6c4f: Already exists
f9101a3ce709: Already exists
bf23a4853928: Already exists
01883943f1fd: Already exists
9cad60a6b584: Already exists
c07be96ae744: Already exists
a3e8098a6e87: Pull complete
56617c2ef90b: Pull complete
bf5772bb3266: Pull complete
Digest: sha256:b24a1f4168c966ec318fb47383d0ba16ac37496394b01e4f6fed8d4e036f011e
Status: Downloaded newer image for gcr.io/cncf-buildpacks-ci/pm/issues/219:0.6.0-builder
ERROR: run image must be specified

  |2.6.3| NY-Floater-15565 in ~/workspace/pack
± zm |tag:v0.5.0 ✓| → git co v0.7.0
Previous HEAD position was c9cfac7 Merge pull request #365 from buildpack/bugfix/null-bom
HEAD is now at 1a4f907 Merge pull request #462 from buildpacks/fix/acceptance-tests

  |2.6.3| NY-Floater-15565 in ~/workspace/pack

  |2.6.3| NY-Floater-15565 in ~/workspace/pack
± zm |tag:v0.7.0 ✓| → make build
> Building...
mkdir -p ./out
CGO_ENABLED=0 go build -ldflags "-X 'github.com/buildpacks/pack/cmd.Version=dev-2020-01-23-16:17:20'" -o ./out/pack -a ./cmd/pack

  |2.6.3| NY-Floater-15565 in ~/workspace/pack
± zm |tag:v0.7.0 ✓| → ./out/pack rebase gcr.io/cncf-buildpacks-ci/pm/issues/219:0.6.0-builder
0.6.0-builder: Pulling from cncf-buildpacks-ci/pm/issues/219
Digest: sha256:b24a1f4168c966ec318fb47383d0ba16ac37496394b01e4f6fed8d4e036f011e
Status: Image is up to date for gcr.io/cncf-buildpacks-ci/pm/issues/219:0.6.0-builder
bionic: Pulling from cnbs/sample-stack-run
Digest: sha256:bbccf4244b2646e8ad69f167b5f6c4240679cc7164b6ef795accd33d573bda95
Status: Image is up to date for cnbs/sample-stack-run:bionic
Rebasing gcr.io/cncf-buildpacks-ci/pm/issues/219:0.6.0-builder on run image cnbs/sample-stack-run:bionic
*** Images (72a6c7fb509b):
      gcr.io/cncf-buildpacks-ci/pm/issues/219:0.6.0-builder
Rebased Image: 72a6c7fb509b1f82f43eaa87c42b7906ff1d9891fd2bed1cc8b4b9eab9ba6e4e
Successfully rebased image gcr.io/cncf-buildpacks-ci/pm/issues/219:0.6.0-builder

  |2.6.3| NY-Floater-15565 in ~/workspace/pack
± zm |tag:v0.7.0 ✓| → ./out/pack rebase gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder
0.5.0-builder: Pulling from cncf-buildpacks-ci/pm/issues/219
Digest: sha256:0662bb6c703ccedeb3671e94d8c0002d8e6c037c93d7a3500ee1cf34db14fe02
Status: Downloaded newer image for gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder
base-cnb: Pulling from cloudfoundry/run
Digest: sha256:ba9998ae4bb32ab43a7966c537aa1be153092ab0c7536eeef63bcd6336cbd0db
Status: Image is up to date for cloudfoundry/run:base-cnb
Rebasing gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder on run image cloudfoundry/run:base-cnb
*** Images (3ba9c2024d76):
      gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder
Rebased Image: 3ba9c2024d76a013c7b139336b3f52e983852dd6b9f40b78d38b420dacb5f70e
Successfully rebased image gcr.io/cncf-buildpacks-ci/pm/issues/219:0.5.0-builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmackie zmackie

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
lifecycle-0.6.0
Development

Successfully merging a pull request may close this issue.

Allow Rebaser to parse metadata of older app images buildpacks/lifecycle
2 participants
@jromero @zmackie