Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieving events returns incorrect start and end time #374

Closed
nitinjavakid opened this issue Dec 3, 2021 · 2 comments
Closed

Retrieving events returns incorrect start and end time #374

nitinjavakid opened this issue Dec 3, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@nitinjavakid
Copy link

Json decode code from plugin to dart code is not using the correct keys. This results in incorrect start and end time of events.

@thomassth
Copy link
Contributor

Oh boy

I traced this back to #316. Apparently said dart file changed, but not the corresponding swift and kotlin files.

In any case it seems to only affect retrieval and not saving events. (Otherwise I would found out on my project)

I'll be pushing fixes in the next few hours.

We really need to invest more effort writing tests to prevent these trivial things.

@thomassth thomassth added the bug Something isn't working label Dec 3, 2021
@nitinjavakid
Copy link
Author

I can confirm that this has been fixed in 4.0.1. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants