Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): rework trait bounds #143

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Jun 19, 2024

Unfortunately, plain &[&[Option<usize>]] path bounds do not accept Arc<[Arc<[Option<usize>]>]> values, which users would likely use, especially in dynamic use cases. On top of that, lack of 'static lifetime on the stream returned by serve prevents it from being passed into e.g. tokio::spawn.
Rework trait bounds to address these issues.

Thanks @LUK3ARK for reporting!

Signed-off-by: Roman Volosatovs <[email protected]>
@rvolosatovs rvolosatovs added this pull request to the merge queue Jun 21, 2024
Merged via the queue into bytecodealliance:main with commit a1ea004 Jun 21, 2024
25 checks passed
@rvolosatovs rvolosatovs deleted the fix/transport-traits branch June 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant