feat(go)!: rework async I/O #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
force-pushed
the
feat/go-async
branch
4 times, most recently
from
d6b2c6d to
4a5c7a3
Compare
rvolosatovs
force-pushed
the
feat/go-async
branch
from
4a5c7a3 to
9de49b1
Compare
brooksmtownsend
approved these changes
Aug 26, 2024
- Remove `Completer` abstraction and just always send async values as "pending" in Go. We may want to revisit this in the future with a better approach (e.g. encoding nested async values concurrently and using a `select` to synchronise at encoding position) - Expose `Close` for stream and future types, although for now the callers have to assert for it. This is not the final solution, just an intermediate state. More breaking changes are incoming for this functionality Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs
force-pushed
the
feat/go-async
branch
from
9de49b1 to
5ba49b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completerabstraction and just always send async values as"pending" in Go. We may want to revisit this in the future with a
better approach (e.g. encoding nested async values concurrently and
using a
selectto synchronise at encoding position)Closefor stream and future types, although for now thecallers have to assert for it.
This is not the final solution, just an intermediate state.
More breaking changes are incoming for this functionality