-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(go,rs): nested async support #346
Merged
rvolosatovs
merged 17 commits into
bytecodealliance:main
from
rvolosatovs:feat/go-nats-unsub
Oct 1, 2024
Merged
fix(go,rs): nested async support #346
rvolosatovs
merged 17 commits into
bytecodealliance:main
from
rvolosatovs:feat/go-nats-unsub
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
0ca81d7
to
024ce22
Compare
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
024ce22
to
b762906
Compare
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoding/decoding nested futures (e.g.
future<future<T>>
) (inconsistently) indexed the inner future with an index of0
.For
future<future<T>>
sent at pathx
, inner, pending, future element would have been sent onx.0
.For example:
pending(pending(true))
would be sent as:x
: 0x00, 0x00x.0
: 0x01WIth this PR:
x
: 0x00, 0x00, 0x01This ensures the implementation is consistent with other types (e.g. results or options) and provides greater optimization opportunities (e.g. client-side data batching)
With the above behavior fixed and made consistent across Go and Rust, this also closes #266, which caused leaking subscriptions in Go using async. If not explicitly type-asserted for
io.Closer
andClose
'd, the subscriptions will be closed using runtime finalizers