Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(transport-quic): rework QUIC transport using transport framing #445

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Nov 1, 2024

  • Reuse a singular QUIC connection for invocations and serving, which eliminates the need for TLS handshake on each invocation
    • Use the same framing mechanism already used for TCP and UDS to facilitate that
  • Increase default framing stream buffer sizes
  • Fix decoding of pending stream<T> values
  • Notify (async) readers on ingress stop
  • Add ConnHandler trait to allow hooking into the async stream tear down procedure (which would be impossible in e.g. Drop, since that would take the values by &mut and we need to run things in an async runtime in a non-blocking fashion - https://docs.rs/quinn/latest/quinn/struct.SendStream.html#method.stopped is particularly tricky)
    • I think we can do better on the API front here, but it's a backwards-compatible stopgap, which works for now - the trait itself is marked experimental
    • Current design allows users to chose the "graceful" or best-effort "fire-and-forget" mode. Not sure yet if the latter has a valid use case, probably when this API is reworked, the "graceful" shutdown behavior should be forced

@rvolosatovs rvolosatovs marked this pull request as draft November 1, 2024 20:28
auto-merge was automatically disabled November 1, 2024 20:28

Pull request was converted to draft

@rvolosatovs rvolosatovs marked this pull request as ready for review November 4, 2024 12:26
@rvolosatovs rvolosatovs enabled auto-merge November 4, 2024 12:29
@rvolosatovs rvolosatovs added this pull request to the merge queue Nov 4, 2024
Merged via the queue into bytecodealliance:main with commit 51b4b3a Nov 4, 2024
36 checks passed
@rvolosatovs rvolosatovs deleted the feat/quic-frame branch November 4, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant