Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom padding #18

Closed
zalmoxisus opened this issue Jan 22, 2016 · 7 comments
Closed

Bottom padding #18

zalmoxisus opened this issue Jan 22, 2016 · 7 comments

Comments

@zalmoxisus
Copy link
Contributor

Could you please publish changes to npm? The current 1.0.0 has bottom padding for the elements except slider bar, so it goes bellow the arrows (I guess it is because I don't use DockMonitor). It is fixed here, but not released yet.

@calesce
Copy link
Owner

calesce commented Jan 23, 2016

I went ahead and published as 1.0.1. I'm still not happy with the layout, though, so I'll leave this issue open. I'll make sure to test without DockMonitor for future changes.

@zalmoxisus
Copy link
Contributor Author

Hey @calesce,

I'm hacking some reusable components for building Redux DevTools monitors (specifically for the extension, but most of them will work for vanilla DevTools as well, except that they will use only the default theme there).

Here's a demo of the slider. From the right panel choose THEME, and you'll be able to change to default/material theme and color schemes.

Please let me know if you're still interested in maintaining and develop this repository further, have time to contribute, and find using my components suitable for Slider Monitor. If you want to keep it as is, I'll go with a separate one. Otherwise, I'd try to contribute it back.

In Redux DevTools Extension 3.0, apart from regular monitors, we'll have monitors for managing the reports, so if we move that part from remotedev-slider, we can deprecate it in favour of redux-slider-monitor. Again, the question is if you want to add additional complexity here.

@calesce
Copy link
Owner

calesce commented Feb 11, 2017

Thanks @zalmoxisus, this looks great. What changes do you propose for this module? I'm interested in supporting DevTools Extension.

@zalmoxisus
Copy link
Contributor Author

Except the UI, the most signifiant change, I guess, will be that instead of showing the current action id, we'll show action type (as slider label). I'll cut a beta of that lib in about a week and will submit a pr with implementation here.

@calesce
Copy link
Owner

calesce commented Feb 11, 2017

👍 This does need UI enhancements, especially the slider handle.

instead of showing the current action id, we'll show action type (as slider label)

Maybe we can show both, or at least have it be configurable? I like being able to see total actions/index of current action.

@zalmoxisus
Copy link
Contributor Author

zalmoxisus commented Feb 12, 2017

The problem is that, due to using of maxAge, we don't have the real index and count of actions. We can show only the correct action id, though it's ambiguous, as the total number of actions we can time travel is not the same as the number of dispatched actions.

We have an option to see the slider value, but for our case we could show action id just in the parenthesis near the action type.

This does need UI enhancements, especially the slider handle.

If you meant the new slider, feel free to amend the css styles and send a pr, I don't see any issues with the handler there.

@calesce
Copy link
Owner

calesce commented Feb 12, 2017

If you meant the new slider

No, I meant the one in this repo 😉 I much prefer the new slider's handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants