-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottom padding #18
Comments
I went ahead and published as 1.0.1. I'm still not happy with the layout, though, so I'll leave this issue open. I'll make sure to test without DockMonitor for future changes. |
Hey @calesce, I'm hacking some reusable components for building Redux DevTools monitors (specifically for the extension, but most of them will work for vanilla DevTools as well, except that they will use only the default theme there). Here's a demo of the slider. From the right panel choose Please let me know if you're still interested in maintaining and develop this repository further, have time to contribute, and find using my components suitable for Slider Monitor. If you want to keep it as is, I'll go with a separate one. Otherwise, I'd try to contribute it back. In Redux DevTools Extension |
Thanks @zalmoxisus, this looks great. What changes do you propose for this module? I'm interested in supporting DevTools Extension. |
Except the UI, the most signifiant change, I guess, will be that instead of showing the current action id, we'll show action type (as slider label). I'll cut a beta of that lib in about a week and will submit a pr with implementation here. |
👍 This does need UI enhancements, especially the slider handle.
Maybe we can show both, or at least have it be configurable? I like being able to see total actions/index of current action. |
The problem is that, due to using of We have an option to see the slider value, but for our case we could show action id just in the parenthesis near the action type.
If you meant the new slider, feel free to amend the css styles and send a pr, I don't see any issues with the handler there. |
No, I meant the one in this repo 😉 I much prefer the new slider's handle. |
Could you please publish changes to npm? The current
1.0.0
has bottom padding for the elements except slider bar, so it goes bellow the arrows (I guess it is because I don't use DockMonitor). It is fixed here, but not released yet.The text was updated successfully, but these errors were encountered: